[SecurityBundle] unhide debug security voter services #29169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd prefer to "unhide" them instead, can you do that, please? |
|
Indeed, it makes more sense. Done. |
nicolas-grekas
approved these changes
Nov 11, 2018
|
Thank you @fmata. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 11, 2018
…mata) This PR was merged into the 4.2-dev branch. Discussion ---------- [SecurityBundle] unhide debug security voter services | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT #27914 introduces `testThatVotersAreNotDecoratedWithoutDebugMode()` which tests if decorated services exist but uses a bad service name without starting dot. Definition in the compiler pass : https://github.com/symfony/symfony/blob/a4204cd685c02377e6e2fbfc7ece98b5563644d9/src/Symfony/Bundle/SecurityBundle/DependencyInjection/Compiler/AddSecurityVotersPass.php#L58-L66 The expected services are hidden and their name start with a dot. So the test will always pass, now it can fails :) Commits ------- 4677bb4 [SecurityBundle] unhide debug security voter services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#27914 introduces
testThatVotersAreNotDecoratedWithoutDebugMode()which tests if decorated services exist but uses a bad service name without starting dot.Definition in the compiler pass :
symfony/src/Symfony/Bundle/SecurityBundle/DependencyInjection/Compiler/AddSecurityVotersPass.php
Lines 58 to 66 in a4204cd
The expected services are hidden and their name start with a dot. So the test will always pass, now it can fails :)