Update HtmlDumper.php #29176
Closed
Update HtmlDumper.php #29176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made the dump search fixed as it's difficult to mange in long page.
|
Also see #28854 where we discussed this. More specifically: #28854 (comment) Or put different; can you add e.g. a (GIF) screenshot, to see how it works now |
|
Here's some work to keep the search bar fixed in view, while scrolling. But the JS needs some work still :) Feel free to take over.. or maybe @ogizanagi can help. Im kinda stuck on this one :) though i got the CSS ok now.. Absolute min width:
Variable max width:
|
|
@zeyad82 Any news? |
|
@ro0NL solution seemed more inclusive. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 27, 2019
This PR was squashed before being merged into the 4.2 branch (closes #29984). Discussion ---------- [VarDumper] Fixed search bar | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Continuation of #28854, replaces #29176 initial:  ctrl f:  scroll:  tested in chrome+ff cc @ogizanagi ref https://caniuse.com/#feat=css-sticky Commits ------- 99d2893 [VarDumper] Fixed search bar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the dump search fixed as it's difficult to mange in long page.