-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Form] Minor fixes in docs and cs #29181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HeahDude
commented
Nov 11, 2018
Q | A |
---|---|
Branch? | 2.8 |
Bug fix? | no |
New feature? | no |
BC breaks? | no |
Deprecations? | no |
Tests pass? | yes |
Fixed tickets | ~ |
License | MIT |
Doc PR | ~ |
f4dd734
to
edffd6f
Compare
edffd6f
to
abe7465
Compare
nicolas-grekas
approved these changes
Nov 11, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(fabbot failure is false positive)
abe7465
to
b22ec24
Compare
fabpot
reviewed
Nov 12, 2018
src/Symfony/Component/Form/Extension/Core/DataMapper/PropertyPathMapper.php
Outdated
Show resolved
Hide resolved
b22ec24
to
de40f5d
Compare
xabbuh
reviewed
Nov 12, 2018
xabbuh
approved these changes
Nov 12, 2018
Thank you @HeahDude. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 13, 2018
This PR was merged into the 2.8 branch. Discussion ---------- [Form] Minor fixes in docs and cs | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ Commits ------- de40f5d [Form] Minor fixes in docs and cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.