[WebProfilerBundle] Fix theme settings #29184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Responsive:
|
ro0NL
commented
Nov 12, 2018
| @@ -1,6 +1,6 @@ | |||
| <style> | |||
| #open-settings { | |||
| color: var(--text-muted); | |||
|
Seems it fixes #28935 as well :) |
stof
reviewed
Nov 12, 2018
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/settings.html.twig
Outdated
Show resolved
Hide resolved
javiereguiluz
approved these changes
Nov 12, 2018
nicolas-grekas
approved these changes
Nov 12, 2018
|
Thank you @ro0NL. |
nicolas-grekas
added a commit
to nicolas-grekas/symfony
that referenced
this pull request
Nov 12, 2018
This PR was squashed before being merged into the 4.2-dev branch (closes symfony#29184). Discussion ---------- [WebProfilerBundle] Fix theme settings | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | symfony#28932 symfony#28935 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Commits ------- 8fbe85c [WebProfilerBundle] Fix theme settings
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.