[TwigBridge] render errors as part of the label only #29207
Conversation
| @@ -270,7 +270,7 @@ | |||
| {# Errors #} | |||
|
|
|||
| {% block form_errors -%} | |||
| {%- if errors|length > 0 -%} | |||
| {%- if render_errors|default(false) and errors|length > 0 -%} | |||
There was a problem hiding this comment.
im not sure i get it.. this makes form_errors practically a no-op by default right?
There was a problem hiding this comment.
Yes, and that's also why I am not convinced that we should make the change in core. It might break custom form themes. I rather tend to fix the documentation instead.
There was a problem hiding this comment.
it could work like form_rest is working maybe; only render errors in form_errors if not already rendered
There was a problem hiding this comment.
either way, 👍 for better docs: customizing form errors inside the label vs. outside the label.
There was a problem hiding this comment.
or maybe make the current feature more explicit: form_label_with_errors? so if you start customizing based on core files you'll understand you need to pick form_label+form_errors vs. form_label_with_errors
|
What's the status here? |
alternative to #29188