[Cache] fix optimizing Psr6Cache for AdapterInterface pools #29243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20e7361 to
48f2efc
Compare
48f2efc to
b8100a9
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Nov 20, 2018
…s (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [Cache] fix optimizing Psr6Cache for AdapterInterface pools | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | -. As described by @Tobion in https://github.com/symfony/symfony/pull/29236/files#r234324045: > The problem I have experienced is that in dev mode the cache is decorated with a TraceableCache. This means it loses this optimization and introduces #28918 (comment) again Commits ------- b8100a9 [Cache] fix optimizing Psr6Cache for AdapterInterface pools
This was referenced Nov 26, 2018
Merged
Merged
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described by @Tobion in https://github.com/symfony/symfony/pull/29236/files#r234324045: