[HttpFoundation] Fixed absolute Request URI with default port #29256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58224ba to
dbde28e
Compare
dbde28e to
310d4d1
Compare
ro0NL
reviewed
Nov 19, 2018
310d4d1 to
2e8f480
Compare
ro0NL
approved these changes
Nov 19, 2018
2e8f480 to
cddce2a
Compare
nicolas-grekas
approved these changes
Nov 20, 2018
fabpot
approved these changes
Nov 24, 2018
|
Thanks for fixing this bug @thomasbisignani. |
fabpot
added a commit
that referenced
this pull request
Nov 24, 2018
…ort (thomasbisignani) This PR was merged into the 3.4 branch. Discussion ---------- [HttpFoundation] Fixed absolute Request URI with default port | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29234 | License | MIT | Doc PR | This PR fixes the #29234 issue, the request URI with default port was not properly generated. Example : ```php $request = Request::create('http://test.com:80/foo'); $request->server->set('REQUEST_URI', 'http://test.com:80/foo'); ``` Before this fix, the `$request->getUri()` method returned `http://test.com/:80/foo` : ```diff Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ -'http://test.com/foo' +'http://test.com/:80/foo' ``` Commits ------- cddce2a [HttpFoundation] Fixed absolute Request URI with default port
This was referenced Nov 26, 2018
Merged
Merged
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the #29234 issue, the request URI with default port was not properly generated.
Example :
Before this fix, the
$request->getUri()method returnedhttp://test.com/:80/foo: