[HttpKernel][WebProfilerBundle] Getting the cached client mime type instead of guessing it again #29285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 for the new approach. Im not sure about "FILES parameters", that's not a real HTTP verb. In HTTP context we're dealing "multipart form-data" (part of the POST params). I suggest to keep the current title. At most it could be moved as |
|
@ro0NL I thought "FILES Parameters" is more according to |
|
Right, but im not sure we should use PHP terminology. It's also |
914ac1c to
3d2877f
Compare
ro0NL
reviewed
Nov 22, 2018
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/request.html.twig
Outdated
Show resolved
Hide resolved
3d2877f to
2e746bc
Compare
|
@ro0NL comments addressed, thanks! |
ro0NL
approved these changes
Nov 22, 2018
fbourigault
approved these changes
Nov 22, 2018
fabpot
approved these changes
Nov 24, 2018
…nstead of guessing it again
2e746bc to
38692a6
Compare
|
Thank you @yceruto. |
fabpot
added a commit
that referenced
this pull request
Nov 24, 2018
…mime type instead of guessing it again (yceruto) This PR was squashed before being merged into the 4.2-dev branch (closes #29285). Discussion ---------- [HttpKernel][WebProfilerBundle] Getting the cached client mime type instead of guessing it again | Q | A | ------------- | --- | Branch? | master (4.2) | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29284 | License | MIT | Doc PR | - The 1st commit fixes the bug based on the current implementation. But I'd like to improve this new feature a little bit with the 2nd commit: * <del>Renaming "Uploaded files" title by "FILES Parameters" and</del> (sub-section of POST parameters) changing the table using key/value structure (being consistent with other sections). * The above allow us also to show nested paramaters. (It is useful to know where this file(s) comes from) * And show all info about the `UploadedFile` object. (It might be useful too)  Commits ------- 38692a6 [HttpKernel][WebProfilerBundle] Getting the cached client mime type instead of guessing it again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 1st commit fixes the bug based on the current implementation. But I'd like to improve this new feature a little bit with the 2nd commit:
Renaming "Uploaded files" title by "FILES Parameters" and(sub-section of POST parameters) changing the table using key/value structure (being consistent with other sections).UploadedFileobject. (It might be useful too)