[WebProfilerBundle] Enable translation filters #29286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
commented
Nov 22, 2018
| @@ -126,7 +126,7 @@ thead.sf-toggle-content.sf-toggle-visible, tbody.sf-toggle-content.sf-toggle-vis | |||
| .filter-list-level li.active { cursor: n-resize; } | |||
| .filter-list-level li.last-active { cursor: default; } | |||
| .filter-list-level li.last-active:before { content: '\2714\00a0'; } | |||
| .filter-list-choice li:before { content: '\2714\00a0'; color: var(--tab-background); } | |||
| .filter-list-choice li:before { content: '\2714\00a0'; color: transparent; } | |||
There was a problem hiding this comment.
in dark mode the checkmark was still visible
nicolas-grekas
approved these changes
Dec 13, 2018
|
Thank you @ro0NL. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 13, 2018
This PR was merged into the 4.3-dev branch. Discussion ---------- [WebProfilerBundle] Enable translation filters | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Enable filters in the translation panel:   Commits ------- 9ae2bb4 [WebProfilerBundle] Enable translation filters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable filters in the translation panel: