-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Console] Fix synopsis when an error occurs #29320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0c959e9
to
ae5150a
Compare
ae5150a
to
1456d19
Compare
Im not sure about the fix. AFAIK the root-cause is a bit deeper, as we wrongly merge the application- and command definitions at some point. It doesnt solve e.g. #17804 |
The last time i took a stab it i ended up with #20054. If i remember well it solved the synopsis as well. |
Should target 3.4 now. Or maybe master btw if this is considered as an improvement. |
("<command>" is displayed but should not be displayed)
1456d19
to
5ee9451
Compare
@nicolas-grekas rebased on 3.4. thanks. |
@ro0NL I think it is normal that this PR doesn't fix #17804. I don't reproduce this bug on Symfony commands. Maybe this bug was existing before in Symfony codebase but it seems to not be the case anymore (or perhaps with a specific behavior ?). I'm ok that this bug still exists in composer, but composer override widely the Application class. IMO it's a composer bug. I read #20054, my PR has not the ambition to rethink the arguments merging between Application and Command. Its goal is more straightforward. In |
but having this unexpected argument in the command definition smells already, right now we're kinda ducktaping it.
I think the issue is still there (4.2) :) |
@ro0NL thanks for your clarifications, I was wrong, so it's not a composer bug. |
Status: Needs Work |
If you like we can re-try #20054 on master. That time i was pretty convinced about it :) |
@ro0NL I'm not sure to understand why you closed it ? |
no feedback :) felt like nobody dares to touch it / get involved :P |
Closed in favor of #20054 |
The short help displayed when an error occurs (synopsis) displays the real command name but also a placeholder for this command name (
debug:container
and<command>
are the same thing):This PR fixes this behavior.