[Form] Handle all case variants of "nan" when parsing a number #29343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...Symfony/Component/Form/Extension/Core/DataTransformer/NumberToLocalizedStringTransformer.php
Outdated
Show resolved
Hide resolved
3164c25 to
a513b40
Compare
a513b40 to
85af682
Compare
nicolas-grekas
approved these changes
Nov 29, 2018
|
Thank you @mwhudson. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 29, 2018
…mber (mwhudson, xabbuh) This PR was merged into the 3.4 branch. Discussion ---------- [Form] Handle all case variants of "nan" when parsing a number | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29321 | License | MIT | Doc PR | n/a NumberToLocalizedStringTransformer::reverseTransform now special cases all case variants of "NaN", not just "NaN" specifically to insulate itself from changing behaviour in ICU. Commits ------- 85af682 add a test case d903dcb [Form] Handle all case variants of "nan" when parsing a number
This was referenced Nov 30, 2018
Merged
Merged
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NumberToLocalizedStringTransformer::reverseTransform now special cases all case variants of "NaN", not just "NaN" specifically to insulate itself from changing behaviour in ICU.