[Debug] workaround opcache bug mutating "$this" !?! #29349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 27, 2018
a6f32ec to
e2b4c8d
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Nov 27, 2018
…as-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [Debug] workaround opcache bug mutating "$this" !?! | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29347 | License | MIT | Doc PR | - This makes absolutely no sense but works around an OPcache bug. Commits ------- e2b4c8d [Debug] workaround opcache bug mutating "$this" !?!
|
has it been reported upstream so that OPCache gets fixed ? |
|
also 4.1 branch is affected. will it be addressed? |
|
@fightbulc We always merge lower branches into more recent branches. So all maintained Symfony versions will get this fix. |
Merged
|
@nicolas-grekas I think we got hit by this bug; after some testing it seems it's opcache optimization 5th pass which triggers this. Setting opcache.optimization_level=0xFFFFFFEFfixed our issue. Has this bug been reported PHP side? Do you have an explanation? |
|
Nope, i didn't report, please do if you want. |
|
If you were able to devise a workaround I guess you know more about this bug than me. Could you share the knowledge? 😃 |
This was referenced Dec 6, 2018
Merged
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes absolutely no sense but works around an OPcache bug.