Skip to content

[Validator] Specify attributes of fileType thanks to ValidatorTypeGuesser #29327 #29352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

BorisCharriere
Copy link

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29327
License MIT
Doc PR symfony

[Form] [Validator]

this fix help the Validator to be more complete and user-friendly. The Validator takes the value of the field mimeTypes and put it into the attribute of the FileType.

@BorisCharriere BorisCharriere changed the title Specify attributes of fileType thanks to ValidatorTypeGuesser [Validator] Specify attributes of fileType thanks to ValidatorTypeGuesser #29327 Nov 27, 2018
@nicolas-grekas nicolas-grekas added this to the next milestone Nov 30, 2018
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks - can you add a test case, please?

@fabpot
Copy link
Member

fabpot commented Mar 4, 2019

@BorisCharriere Still interested in finishing this PR?

@BorisCharriere
Copy link
Author

@fabpot No, you can close it, I'll keep changes on my side and work on them when i'll have more time

@fabpot fabpot closed this Mar 4, 2019
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants