[DI] fix combinatorial explosion when analyzing the service graph #29369
Conversation
…e graph (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [DI] fix combinatorial explosion when analyzing the service graph | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29336 | License | MIT | Doc PR | - and a few minor things found meanwhile. Commits ------- 0d0be12 [DI] fix combinatorial explosion when analyzing the service graph
There was a problem hiding this comment.
@nicolas-grekas thank you! The performance is now again near the 4.1.7 version:
Current benchmark:
v4.1.7: 8,85s user 1,02s system 98% cpu 9,987 total
v4.1.8: 68,62s user 1,42s system 98% cpu 1:05,01 total
v4.1.8 with this patch: 11,52s user 1,29s system 94% cpu 13,576 total
| } | ||
| } | ||
| $this->container->getCompiler()->getServiceReferenceGraph()->clear(); | ||
| $checkedNodes = array(); |
There was a problem hiding this comment.
looks unused? should it be unset($checkedNodes);?
There was a problem hiding this comment.
could be but that wouldn't provide anything more so not really needed
There was a problem hiding this comment.
unset would avoid IDE or code style checker marking it as unused variable so nobody would remove it accidentally ;).
But I'm happy that the container now only take some seconds to build again 😄
|
@alexander-schranz thanks for the confirmation. |
and a few minor things found meanwhile.