[Routing] fix trailing slash redirection #29373
Conversation
nicolas-grekas
commented
Nov 29, 2018
| Q | A |
|---|---|
| Branch? | 4.1 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #29363 |
| License | MIT |
| Doc PR | - |
This PR was merged into the 4.1 branch. Discussion ---------- [Routing] fix trailing slash redirection | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29363 | License | MIT | Doc PR | - Commits ------- fbaba23 [Routing] fix trailing slash redirection
|
Hm, this does not seem to fix the issue for me. Btw, what is the easiest/best way to check this ? I manually copy/pasted your changes in my vendor folder now. |
|
Now that it's merged, you can require |
|
I don't know if is the same issue, but I have a problem with the route /{id}/ The route matches but the id parameter value is appended with the '/'. For example /1/ . The id value should be "1" but i get "1/" This problem began with version 4.1.8 and with this patch the problem remains. |
|
any reproducer? |
|
I've created a demo app to reproduce the issue. If you try to access /user/ or /admin/, you'll get the error while those routes are ok according to debug:router. |
|
@jimmycleuren thanks understood, I'm on it (#29380 fixes it but is still not finished) |