[Validator] Allow ConstraintViolation::__toString() to expose codes that are not null or emtpy strings
#29375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
reviewed
Nov 30, 2018
| @@ -79,13 +79,13 @@ public function __toString() | |||
| } | |||
|
|
|||
| $propertyPath = (string) $this->propertyPath; | |||
| $code = $this->code; | |||
| $code = trim($this->code); | |||
There was a problem hiding this comment.
trimming is a new behavior, which IMHO is not needed.
There was a problem hiding this comment.
I understand your point, and I agree. My concern was originated by the absence of delimiters around the printed code, so I thought that readability could be improved trimming any undesired blankspace around the code.
There was a problem hiding this comment.
the delimiter is (code and ) :)
undesired blankspace
we don't know that
There was a problem hiding this comment.
I mean cases like
(code )
I think it is not clear which space comes from the dumped message and which one comes from the actual code, but I'm pretty sure this is an edge case that we can ignore.
ro0NL
approved these changes
Nov 30, 2018
nicolas-grekas
approved these changes
Nov 30, 2018
|
Updated base to target 3.4. |
… that are not null or emtpy strings
1cbe5dc to
7bb0fb5
Compare
|
Thank you @phansys. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 1, 2018
…xpose codes that are not null or emtpy strings (phansys) This PR was squashed before being merged into the 3.4 branch (closes #29375). Discussion ---------- [Validator] Allow `ConstraintViolation::__toString()` to expose codes that are not null or emtpy strings |Q |A | |--- |---| |Branch |2.8| |Bug fix? |yes| |New feature? |no | |BC breaks? |no | |Deprecations?|no | |Tests pass? |yes| |Fixed tickets|n/a| |License |MIT| |Doc PR |n/a| Allow to expose `0` or `"0"` validation codes. Commits ------- 7bb0fb5 [Validator] Allow `ConstraintViolation::__toString()` to expose codes that are not null or emtpy strings
This was referenced Dec 6, 2018
Merged
Closed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to expose
0or"0"validation codes.