[DI] fix edge case in InlineServiceDefinitionsPass #29393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Nov 30, 2018
nicolas-grekas
added a commit
that referenced
this pull request
Dec 1, 2018
…s-grekas) This PR was merged into the 4.1 branch. Discussion ---------- [DI] fix edge case in InlineServiceDefinitionsPass | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Looks like this can happen - dunno how https://stackoverflow.com/questions/53558247/autowire-services-test-yaml-there-is-no-node-with-id-service-a Commits ------- 8bd2bbf [DI] fix edge case in InlineServiceDefinitionsPass
|
Are there a workarround time to wait for next release ? |
|
@kevin-lot the normal schedule (i.e. outside security releases) is to have a patch release once per month (generally at the end of the month) |
|
Is there a specific reason why this was not merged into v3.4.20 (v3.4.19...v3.4.20)? We experience an issue with doctrine filters (https://packagist.org/packages/gedmo/doctrine-extensions + https://packagist.org/packages/stof/doctrine-extensions-bundle) that cannot be found after this patch. |
|
About 3.4, this patch doesn't apply there. About any other issue, we're not aware of anything until someone opens an issue ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this can happen - dunno how
https://stackoverflow.com/questions/53558247/autowire-services-test-yaml-there-is-no-node-with-id-service-a