[FrameworkBundle][Messenger] Restore check for messenger serializer default id #29395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Dec 1, 2018
|
Thank you @ogizanagi. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 1, 2018
…erializer default id (ogizanagi) This PR was merged into the 4.2 branch. Discussion ---------- [FrameworkBundle][Messenger] Restore check for messenger serializer default id | Q | A | ------------- | --- | Branch? | 4.2 <!-- see below --> | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | https://symfony-devs.slack.com/archives/C9PQ75TV3/p1543590611003500 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A From Slack: > @adamquaile [4:10 PM] > So, I just updated to 4.2 today, and got this message: > > The default Messenger serializer cannot be enabled as the Serializer support is not available. Try enabling it or running "composer require symfony/serializer-pack" > > In the docs it's stated: > > In order to use Symfony's built-in AMQP transport, you will need the Serializer Component. Ensure that it is installed with: > >But I haven't yet configured AMQP - I'm using my own transport. Should I be getting this exception? --- This check was removed in #28405, but is actually still necessary to not fail as soon as you can install the Messenger component without the Serializer one installed. Commits ------- 1cf17c0 [FrameworkBundle][Messenger] Restore check for messenger serializer default id
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Slack:
This check was removed in #28405, but is actually still necessary to not fail as soon as you can install the Messenger component without the Serializer one installed.