[Serializer] fixed DateTimeNormalizer to maintain microseconds when a different timezone required #29413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
reviewed
Dec 1, 2018
| $object = clone $object; | ||
| } | ||
|
|
||
| $object = $object->setTimezone($timezone); |
There was a problem hiding this comment.
mutating the original datetime is a change, but we safely clone any datetime no? https://3v4l.org/gdLh0
There was a problem hiding this comment.
in clear, you mean the change should be just:
$object = (clone $object)->setTimezone($timezone);
There was a problem hiding this comment.
@nicolas-grekas i can't do it in one line because php 5.5 don't support it
nicolas-grekas
approved these changes
Dec 2, 2018
… different timezone required
|
Thank you @rvitaliy. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 2, 2018
…onds when a different timezone required (rvitaliy) This PR was squashed before being merged into the 3.4 branch (closes #29413). Discussion ---------- [Serializer] fixed DateTimeNormalizer to maintain microseconds when a different timezone required | Q | A | ------------- | --- | Branch? | 3.4 up to 4.2 for bug fixes | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | # | License | MIT | Doc PR | none fixed `DateTimeNormalizer::normalizer()` when `$object` is mutated internally to change timezone we lost microseconds of origina `$object` Commits ------- 2bf8a1c [Serializer] fixed DateTimeNormalizer to maintain microseconds when a different timezone required
This was referenced Dec 6, 2018
Merged
Closed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed
DateTimeNormalizer::normalizer()when$objectis mutated internally to change timezone we lost microseconds of origina$object