[Cache] Fixed Memcached adapter doClear()to call flush() #29436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Flushing clears completely the Memcache server, while clear should only affect the very items that are in one logical pool (ie same key prefix). Invalidation works already by using an incrementing version number as prefix. |
|
@nicolas-grekas But if you pass option to not use versioning? $adapter = new MemcachedAdapter($client, $namespace);
$adapter->enableVersioning(false); |
nicolas-grekas
approved these changes
Dec 3, 2018
|
@nicolas-grekas How long it will take before it gets merged? Thx |
|
Thank you @raitocz. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 6, 2018
…raitocz) This PR was submitted for the master branch but it was squashed and merged into the 3.4 branch instead (closes #29436). Discussion ---------- [Cache] Fixed Memcached adapter doClear()to call flush() | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29435 | License | MIT | Doc PR | symfony/symfony-docs MemcachedTrait now calls Memcached::flush via its client instead of just returning false. Commits ------- 447baac [Cache] Fixed Memcached adapter doClear()to call flush()
This was referenced Dec 6, 2018
Merged
Closed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MemcachedTrait now calls Memcached::flush via its client instead of just returning false.