[Workflow] Fixed BC break for Workflow metadata #29444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @lyrixx. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 3, 2018
This PR was merged into the 4.1 branch. Discussion ---------- [Workflow] Fixed BC break for Workflow metadata | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29427 | License | MIT | Doc PR | I used SplObjectStorage to store the transition metadata. So we need to use the exact same PHP Object. Commits ------- 5691818 [Workflow] Fixed BC break for Workflow metadata
| $this->assertInstanceOf(Definition::class, $params[0]); | ||
| $this->assertSame(Workflow\Transition::class, $params[0]->getClass()); | ||
| $this->assertSame(array('submit', 'start', 'travis'), $params[0]->getArguments()); | ||
| $this->assertSame(array('title' => 'transition submit title'), $params[1]); |
There was a problem hiding this comment.
Can we keep the test of array('title' => 'transition submit title')?
There was a problem hiding this comment.
No. It's not an instance of transition anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used SplObjectStorage to store the transition metadata.
So we need to use the exact same PHP Object.