Skip to content

[FrameworkBundle] Fix empty output for debug:autowiring when reflection-docblock is not installed #29445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2018

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Dec 3, 2018

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29442
License MIT
Doc PR n/a

screenshot 2018-12-03 at 19 25 07

instead of no output at all when phpdocumentor/reflection-docblock is not installed

@chalasr chalasr changed the title Fix empty output for debug:autowiring when reflection-docblock is not installed [FrameworkBundle] Fix empty output for debug:autowiring when reflection-docblock is not installed Dec 3, 2018
@chalasr chalasr added this to the 4.2 milestone Dec 3, 2018
@chalasr chalasr force-pushed the debug-autowiring-empty-output branch from 2fb2e24 to bd0dbe4 Compare December 3, 2018 18:37
@nicolas-grekas
Copy link
Member

Thank you @chalasr.

@nicolas-grekas nicolas-grekas merged commit bd0dbe4 into symfony:4.2 Dec 3, 2018
nicolas-grekas added a commit that referenced this pull request Dec 3, 2018
…en reflection-docblock is not installed (chalasr)

This PR was merged into the 4.2 branch.

Discussion
----------

[FrameworkBundle] Fix empty output for debug:autowiring when reflection-docblock is not installed

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29442
| License       | MIT
| Doc PR        | n/a

![screenshot 2018-12-03 at 19 25 07](https://user-images.githubusercontent.com/7502063/49393383-549f8a00-f731-11e8-822c-43959514c69d.png)

instead of no output at all when phpdocumentor/reflection-docblock is not installed

Commits
-------

bd0dbe4 Fix empty output for debug:autowiring when reflection-docblock is not available
@chalasr chalasr deleted the debug-autowiring-empty-output branch December 3, 2018 21:40
@fabpot fabpot mentioned this pull request Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants