[WebProfilerBundle] add margin-bottom to caption #2957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What does it fix? |
|
Just a minor design issue with table captions. Without: http://dl.dropbox.com/u/548684/PR2957/without-margin.png I currently hold it in a custom css, but thought it is generic enough to be put into the bundle. |
|
@havvg What custom bundle is that ? and what does it show? look interesting |
|
@henrikbjorn It's a bundle (not published yet, https://github.com/havvg/HavvgCloudcontrolBundle) adding features to fully utilize applications on http://cloudcontrol.com PaaS. |
fabpot
added a commit
that referenced
this pull request
Dec 28, 2011
Commits ------- 41950a6 [WebProfilerBundle] add margin-bottom to caption Discussion ---------- [WebProfilerBundle] add margin-bottom to caption --------------------------------------------------------------------------- by fabpot at 2011/12/26 13:15:57 -0800 What does it fix? --------------------------------------------------------------------------- by havvg at 2011/12/27 02:46:16 -0800 Just a minor design issue with table captions. Without: http://dl.dropbox.com/u/548684/PR2957/without-margin.png With: http://dl.dropbox.com/u/548684/PR2957/with-margin.png I currently hold it in a custom css, but thought it is generic enough to be put into the bundle. --------------------------------------------------------------------------- by henrikbjorn at 2011/12/27 04:03:53 -0800 @havvg What custom bundle is that ? and what does it show? look interesting --------------------------------------------------------------------------- by havvg at 2011/12/27 04:40:18 -0800 @henrikbjorn It's a bundle (not published yet, https://github.com/havvg/HavvgCloudcontrolBundle) adding features to fully utilize applications on http://cloudcontrol.com PaaS.
xabbuh
added a commit
to xabbuh/symfony
that referenced
this pull request
Jan 14, 2019
In symfony#29853 the bugfix made in symfony#29597 was reverted as it did not work as expected. This fixture file has been modified after the 3.4 branch was merged up to account for the changes made in symfony#2957 and must now be reverted to the former state too.
fabpot
added a commit
that referenced
this pull request
Jan 15, 2019
…abbuh) This PR was merged into the 4.2 branch. Discussion ---------- [DependencyInjection] fix test after revert of bugfix | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | In #29853 the bugfix made in #29597 was reverted as it did not work as expected. This fixture file has been modified after the 3.4 branch was merged up to account for the changes made in #2957 and must now be reverted to the former state too. Commits ------- 81f63b1 fix test after revert of bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.