[VarDumper] Use hyperlinks in CliDescriptor #29613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Dec 15, 2018
|
Problem with this is that link will be now inaccessible for users not using terminal which supports hyperlinks |
|
@ostrolucky true. I think that's fine personally: most common terminals handle the links already and windows didn't make it clickable anyway. |
|
yeah not a big deal in this one case, it's really minor inconvenience |
|
Thank you @ogizanagi. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 20, 2018
This PR was merged into the 4.3-dev branch. Discussion ---------- [VarDumper] Use hyperlinks in CliDescriptor | Q | A | ------------- | --- | Branch? | master <!-- see below --> | Bug fix? | no | New feature? | yes <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | Part of #29585 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Leverages #29168 to add the hyperlink directly on the source text instead of printing below: #### Before (or with `symfony/console < 4.3`)  #### After  Commits ------- e54e219 [VarDumper] Use hyperlinks in CliDescriptor
|
I wonder how this could be leveraged with awesome console PHPStorm plugin |
|
Well, using this plugin, there's nothing much to do: both Problem is though the hyperlink feature used here breaks the whole PhpStorm terminal emulator :/ Perhaps we could maintain a list of terminals actually supporting this feature to avoid such issues (at least ignore hyperlinks for PhpStorm terminal emulator, i.e: |
fabpot
added a commit
that referenced
this pull request
Dec 23, 2018
This PR was merged into the 4.1 branch. Discussion ---------- [VarDumper] Add descriptors tests | Q | A | ------------- | --- | Branch? | 4.1 <!-- see below --> | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Just adding some tests for these classes & fixing a small issue with the optional `project_dir` entry from `source` context provider. If merged before #29613, I'll update tests in it (796ca6b) (otherwise could be picked on merge). Commits ------- 8570b8a [VarDumper] Add descriptors tests
chalasr
pushed a commit
that referenced
this pull request
Dec 29, 2018
…lator (ogizanagi) This PR was merged into the 4.3-dev branch. Discussion ---------- [Console][VarDumper] Ignore href for PhpStorm terminal emulator | Q | A | ------------- | --- | Branch? | master <!-- see below --> | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #29613 (comment) <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A So, as explained in #29613 (comment), the hyperlink feature currently breaks the PhpStorm terminal (the output stops abruptly, sometimes the whole terminal emulator freezes). Currently, a simple `dump(new \Exception());` would be enough to break it. Hence I think we should at least ignore hyperlinks for this terminal emulator. 📝 https://youtrack.jetbrains.com/issue/IDEA-204536 feature request has been opened on JetBrains YouTrack. Commits ------- 0f65a76 [Console][VarDumper] Ignore href for PhpStorm terminal emulator
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leverages #29168 to add the hyperlink directly on the source text instead of printing below:
Before (or with
symfony/console < 4.3)After