Skip to content

Extracts TraceableAdapterEvent class to its own file #29640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Extracts TraceableAdapterEvent class to its own file #29640

wants to merge 2 commits into from

Conversation

ilirhxh
Copy link

@ilirhxh ilirhxh commented Dec 18, 2018

Q A
Branch? 4.2
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #...
License MIT
Doc PR

@ilirhxh ilirhxh changed the title Extracts TraceableAdapterEvent class to it's own file Extracts TraceableAdapterEvent class to its own file Dec 18, 2018
@stof
Copy link
Member

stof commented Dec 18, 2018

I think the fact it was not autoloadable was done on purpose. If we move it to its own file, we should probably mark it as @internal

@ro0NL
Copy link
Contributor

ro0NL commented Dec 18, 2018

ref #21082 (review)

@nicolas-grekas
Copy link
Member

@stof is right, this class is not supposed to be autoloadable so the current design is on purpose. Thanks for submitting.

@nicolas-grekas nicolas-grekas added this to the 4.2 milestone Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
5 participants
@ilirhxh @stof @ro0NL @nicolas-grekas @carsonbot