[Validator] Choices constraint improvement #29658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can be closed as this feature is supported by the annotation reader already, just remove the quotes :). /**
* @var string
*
* @Assert\Choice(choices=App\Constants::AVAILABLE_STATES)
*/
private $state; |
|
@HeahDude Do you meant |
|
yes x). |
HeahDude
reviewed
Dec 21, 2018
| @@ -100,6 +116,7 @@ public function validate($value, Constraint $constraint) | |||
| } elseif (!\in_array($value, $choices, true)) { | |||
| $this->context->buildViolation($constraint->message) | |||
| ->setParameter('{{ value }}', $this->formatValue($value)) | |||
| ->setParameter('{{ choices }}', implode(', ', $choices)) | |||
There was a problem hiding this comment.
Ah this line is still a nice addition indeed!
|
yeah indeed, you're right, and i 've learnt something new :) |
|
I'm 👍 for supporting a default choices implode, as long as we don't change the default message for both BC and let it opt-in performance wise. |
|
i've updated the PR |
ro0NL
reviewed
Dec 21, 2018
| @@ -100,6 +100,7 @@ public function validate($value, Constraint $constraint) | |||
| } elseif (!\in_array($value, $choices, true)) { | |||
| $this->context->buildViolation($constraint->message) | |||
| ->setParameter('{{ value }}', $this->formatValue($value)) | |||
| ->setParameter('{{ choices }}', implode(', ', $choices)) | |||
There was a problem hiding this comment.
should also be added to the multiple=true case
choices can be any value, i think we need to map all choices using formatValue() also.
There was a problem hiding this comment.
yep, you're totally right - i've added to the multiple=true case and formatted the value
|
@nikophil Can you please update the PR title and description to match the recent changes (they will be part of the git history)? |
|
done 👍 |
xabbuh
approved these changes
Dec 27, 2018
HeahDude
approved these changes
Dec 27, 2018
fabpot
approved these changes
Jan 2, 2019
|
Thank you @nikophil. |
fabpot
added a commit
that referenced
this pull request
Jan 2, 2019
This PR was merged into the 4.3-dev branch. Discussion ---------- [Validator] Choices constraint improvement | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Hi, here is a little improvement for the choice constraint: expose a new `choices` wildcard for the messages, in order to provide a way to display easily the valid choices to the user. thanks. Commits ------- 71dfa35 add new `choices` wildcard in message
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jan 3, 2019
…int (nikophil) This PR was submitted for the 3.4 branch but it was merged into the master branch instead (closes #10836). Discussion ---------- document "choices" wildcard in Choice validation constraint Hello, here is a little doc update in order to document the `choices` wildcard introduced by symfony/symfony#29658 Commits ------- 7764519 document "choices" wildcard in Choice validation constraint
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Mar 7, 2019
…ation (nikophil) This PR was squashed before being merged into the 3.4 branch (closes #10810). Discussion ---------- [Validator] Explained how to use array constant in annotation Hi, few days ago i tried to add a new feature to the `choice` validator constraint, by adding a new `choicesFromConstant` option. symfony/symfony#29658 But then, i realized this was already supported. I think this should be documented, as i think a lot of people don't know this feature. thanks. Commits ------- 7774aab [Validator] Explained how to use array constant in annotation
Merged
przemyslaw-bogusz
added a commit
to przemyslaw-bogusz/symfony-docs
that referenced
this pull request
Feb 8, 2020
It was added in this PR: symfony/symfony#29658
javiereguiluz
pushed a commit
to przemyslaw-bogusz/symfony-docs
that referenced
this pull request
Feb 10, 2020
It was added in this PR: symfony/symfony#29658
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Feb 10, 2020
…s (przemyslaw-bogusz) This PR was submitted for the 5.0 branch but it was merged into the 4.4 branch instead (closes #13081). Discussion ---------- [Constraints][Choice] Added choices to message parameters It was added in this PR: symfony/symfony#29658 <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 3ba67f7 Added choices to message parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
here is a little improvement for the choice constraint: expose a new
choiceswildcard for the messages, in order to provide a way to display easily the valid choices to the user.thanks.