[Filesystem] Support resources and deprecate using arrays in dumpFile() and appendToFile() #29661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Dec 23, 2018
nicolas-grekas
approved these changes
Dec 24, 2018
chalasr
requested changes
Dec 26, 2018
javiereguiluz
approved these changes
Dec 26, 2018
|
Would need a separate PR, but would you accept a new method that takes a resource? |
|
What about reusing the same method? |
|
I would be in favor of supporting resources and strings in the existing method. |
|
@fabpot Updated to match. |
fabpot
approved these changes
Mar 3, 2019
…() and appendToFile()
|
Thank you @thewilkybarkid. |
fabpot
added a commit
that referenced
this pull request
Mar 3, 2019
…ays in dumpFile() and appendToFile() (thewilkybarkid) This PR was squashed before being merged into the 4.3-dev branch (closes #29661). Discussion ---------- [Filesystem] Support resources and deprecate using arrays in dumpFile() and appendToFile() | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Running PHPStan on my project picked up that passing a resource to `Filesystem::dumpFile()` didn't match the documented type. I found this has been discussed in #20980 and #28019, without a clear result. But, my reading is that only strings should be supported. While I think that not supporting streams makes this a lot less useful (and I'm going to switch away from it), this does need to be resolved. So, I've deprecated using arrays and resources. Commits ------- 0eaf9d2 [Filesystem] Support resources and deprecate using arrays in dumpFile() and appendToFile()
Merged
|
The current type-hints that were added in 5.x for these methods prevent us from passing resources because the file is type-hinted as Update: this only breaks on Windows for some reason... this is my workaround to deal with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running PHPStan on my project picked up that passing a resource to
Filesystem::dumpFile()didn't match the documented type.I found this has been discussed in #20980 and #28019, without a clear result. But, my reading is that only strings should be supported. While I think that not supporting streams makes this a lot less useful (and I'm going to switch away from it), this does need to be resolved. So, I've deprecated using arrays and resources.