[Form] Add new block_prefix option for an easy form theming #29680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yceruto
commented
Dec 25, 2018
•
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #29651 |
| License | MIT |
| Doc PR | symfony/symfony-docs#10835 |
HeahDude
approved these changes
Dec 25, 2018
|
Thank you @HeahDude for your quick review and merry Christmas! |
OskarStark
approved these changes
Dec 26, 2018
OskarStark
reviewed
Dec 26, 2018
| multiple data | ||
| placeholder disabled | ||
| preferred_choices help | ||
| help_attr |
There was a problem hiding this comment.
hmpf this table rst layout makes it hard for small and readable diffs, because in this case only one string is changed (added)
xabbuh
reviewed
Jan 1, 2019
f0d120f to
bd50ac4
Compare
|
Doc PR created. (AppVeyor failure is unrelated) |
nicolas-grekas
approved these changes
Jan 3, 2019
fabpot
approved these changes
Jan 3, 2019
|
Thank you @yceruto. |
fabpot
added a commit
that referenced
this pull request
Jan 3, 2019
…eming (yceruto) This PR was merged into the 4.3-dev branch. Discussion ---------- [Form] Add new block_prefix option for an easy form theming | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29651 | License | MIT | Doc PR | symfony/symfony-docs#10835 Commits ------- bd50ac4 Add block_prefix option for an easy form theming
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jan 22, 2019
This PR was squashed before being merged into the master branch (closes #10835). Discussion ---------- [Form] Documenting the block_prefix option Documenting new feature: symfony/symfony#29680 Commits ------- d9382d4 [Form] Documenting the block_prefix option
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.