[FrameworkBundle] access the container getting it from the kernel #29708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Dec 28, 2018
| Q | A |
|---|---|
| Branch? | 4.1 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #29707 |
| License | MIT |
| Doc PR |
xabbuh
commented
Dec 28, 2018
fabpot
approved these changes
Jan 2, 2019
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jan 2, 2019
… kernel (xabbuh) This PR was submitted for the master branch but it was merged into the 4.1 branch instead (closes #29708). Discussion ---------- [FrameworkBundle] access the container getting it from the kernel | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29707 | License | MIT | Doc PR | Commits ------- 68ea3f1 access the container getting it from the kernel
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Jan 13, 2019
…tall command (xabbuh) This PR was merged into the 4.3-dev branch. Discussion ---------- [FrameworkBundle] pass project dir into the assets install command | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | symfony/symfony#29708 (comment) | License | MIT | Doc PR | Commits ------- b373d4206b pass project dir into the assets install command
fabpot
added a commit
that referenced
this pull request
Jan 13, 2019
…tall command (xabbuh) This PR was merged into the 4.3-dev branch. Discussion ---------- [FrameworkBundle] pass project dir into the assets install command | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #29708 (comment) | License | MIT | Doc PR | Commits ------- b373d42 pass project dir into the assets install command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.