[Profiler] Still show locale and fallback locale even if no trans used #29780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would indeed remove the duplicated metrics. |
ro0NL
approved these changes
Jan 4, 2019
fabpot
approved these changes
Jan 5, 2019
|
Thank you @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
Jan 5, 2019
…if no trans used (ogizanagi) This PR was squashed before being merged into the 4.3-dev branch (closes #29780). Discussion ---------- [Profiler] Still show locale and fallback locale even if no trans used | Q | A | ------------- | --- | Branch? | master <!-- see below --> | Bug fix? | no | New feature? | yes <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Even if no translation is used for the current request, this information can still be valuable and displayed in the panel. ### Before  ### After  and with messages, move locales info first:  Actually, following metrics are redundant with the tabs count. Not convinced we should duplicate it. Edit: removed --- Note we also collect the locale set into the request from the `RequestDataCollector`, but we never use it. Should we display it somewhere in the request panel? Commits ------- d80bfad [Profiler] Still show locale and fallback locale even if no trans used
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if no translation is used for the current request, this information can still be valuable and displayed in the panel.
Before
After
and with messages, move locales info first:
Actually, following metrics are redundant with the tabs count. Not convinced we should duplicate it.
Edit: removed
Note we also collect the locale set into the request from the
RequestDataCollector, but we never use it. Should we display it somewhere in the request panel?