Skip to content

[DI] Add trim env processor #29781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2019
Merged

[DI] Add trim env processor #29781

merged 1 commit into from
Jan 6, 2019

Conversation

ogizanagi
Copy link
Contributor

@ogizanagi ogizanagi commented Jan 4, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #26708
License MIT
Doc PR symfony/symfony-docs#10851

Which is especially useful in combination with the file env processor.

@ogizanagi
Copy link
Contributor Author

(fabbot failure fixed in b309344)

@xabbuh
Copy link
Member

xabbuh commented Jan 4, 2019

Should we add it to the changelog?

@ogizanagi
Copy link
Contributor Author

Changelog entry added, thanks

@fabpot
Copy link
Member

fabpot commented Jan 6, 2019

Thank you @ogizanagi.

@fabpot fabpot merged commit e226492 into symfony:master Jan 6, 2019
fabpot added a commit that referenced this pull request Jan 6, 2019
This PR was merged into the 4.3-dev branch.

Discussion
----------

[DI] Add trim env processor

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #26708  <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | Todo

Which is especially useful in combination with the `file` env processor.

Commits
-------

e226492 [DI] Add trim env processor
@ogizanagi ogizanagi deleted the trim_processor branch January 6, 2019 16:50
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request Jan 7, 2019
This PR was merged into the master branch.

Discussion
----------

[DI] Document the `trim` env var processor

Ref: symfony/symfony#29781

Commits
-------

d36f631 [DI] Document the `trim` env var processor
@fabpot fabpot mentioned this pull request May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants