Use HTTP_NOT_FOUND constant in NotFountHttpException #29812
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
released v3.4.21
This PR was merged into the 3.4 branch. Discussion ---------- [fabbot] enable short arrays | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Let's move to short arrays, but let's do it in a smooth way. This PR enables short arrays for php-cs-fixer, making PRs red when they don't follow the CS. We should then ask all authors of pending PRs to rebase their PR and apply the CS patch. This will need some time. Then, in 1-2 months, we'll be able to move all the code base to short arrays without creating hundred merge conflicts with all pending PRs, hopefully. Commits ------- 84e72e0 [fabbot] enable short arrays
2e07f17 to
4b0eb17
Compare
|
ref #22023 |
|
Closing for reasons given in the ticket referenced by @ro0NL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Response::HTTP_NOT_FOUND (404) constant (from HttpFoundation component) instead of 404 when providing the status code in the Exception message.