-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Form] Add LocaleTypeTest::testInvalidLocaleMessage()
#29828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LocaleTypeTest::testInvalidLocaleMessage()
LocaleTypeTest::testInvalidLocaleMessage()
The current behaviour is expected. The |
Thank you for the response. |
Yes, that's right. But you can use the |
In that case, I should instantiate manually the |
Should we merge this PR? If yes, please rebase to account for short arrays. If needed, please open an issue if there is anything to keep track of. |
e760446
to
e882dfb
Compare
The added test is failing as expected. I think for cases where the current behaviour is not sufficient enough, having to configure the |
Thank for your response. I think this behavior was changed between |
I think that's because before #29500 was merged, the |
Closing based on the given explanation. Thank you! |
Since passing a invalid locale causes the form to be not synchronized, the validation fails because this reason instead of the locale validation.
Since I don't know if this is the expected result, this PR provides a test covering the described behavior in order to clarify the situation.