[BrowserKit] Various changes to the Response class #29881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
commented
Jan 14, 2019
| * | ||
| * @return int The response status code | ||
| */ | ||
| public function getStatusCode(): int |
There was a problem hiding this comment.
Consistent with the method name used by HttpFoundation
| */ | ||
| class Response | ||
| { | ||
| /** @internal */ |
There was a problem hiding this comment.
@final is enough, just to be extra clear.
fb40550 to
c13438c
Compare
nicolas-grekas
approved these changes
Jan 14, 2019
c13438c to
9045a4e
Compare
javiereguiluz
approved these changes
Jan 14, 2019
stof
approved these changes
Jan 14, 2019
fabpot
added a commit
that referenced
this pull request
Jan 14, 2019
…bpot) This PR was squashed before being merged into the 4.3-dev branch (closes #29881). Discussion ---------- [BrowserKit] Various changes to the Response class | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | yes | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a This is the first PR of a series when I'm trying to "modernize" BrowserKit. Commits ------- 9045a4e [BrowserKit] marked Response as @Final 0abff98 [BrowserKit] deprecated Response::buildHeader() e8e5235 [BrowserKit] deprecated Response::getStatus() in favor of Response::getStatusCode()
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR of a series when I'm trying to "modernize" BrowserKit.