Fix the expected result of the PhpFileLoaderTest #29888
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any reason why the 7.1 test still loads the old file? Some caching issue? |
|
I think we can also migrate to Travis CI for testing on Windows as AppVeyor seems to be still unstable. |
|
Thank you for proposing. But this was fixed in the meantime merging #29886. |
|
Oh ok, thanks for the info. |
|
Looks a bit weird. The only difference I spot is that your PR targets |
|
At least master is green now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI is currently failing due to changes in the
PhpFileLoaderTestassertion.This PR tries to fix it.