[Serializer] Docblock about throwing exceptions on serializer #29889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also I believe that doblocks must be added to Serializer class as well. |
nicolas-grekas
approved these changes
Jan 24, 2019
dunglas
approved these changes
Jan 25, 2019
5178fcc to
0b44ad7
Compare
|
Thanks @gmponos. |
dunglas
added a commit
that referenced
this pull request
Jan 25, 2019
…lizer (gmponos) This PR was squashed before being merged into the 3.4 branch (closes #29889). Discussion ---------- [Serializer] Docblock about throwing exceptions on serializer | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Most of the serializers can throw a `\Symfony\Component\Serializer\ExceptionInterface`. This makes the docblock in line with that. Similar to this #29832 Commits ------- 0b44ad7 [Serializer] Docblock about throwing exceptions on serializer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the serializers can throw a
\Symfony\Component\Serializer\ExceptionInterface. This makes the docblock in line with that.Similar to this #29832