Allow exchange type headers binding #29983
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the use of headers exchange to deliver messages by defining the headers to bind. When binding a exchange of type headers to a queue, adding the arguments allows you to define the message routing correctly.
sroze
reviewed
Jan 27, 2019
src/Symfony/Component/Messenger/Transport/AmqpExt/Connection.php
Outdated
Show resolved
Hide resolved
CedrickOka
commented
Feb 3, 2019
There was a problem hiding this comment.
@sroze Your remarks have been taken into account and I took the opportunity to fix a bug
|
friendly ping @sroze |
|
@CedrickOka thank you very much for this. I’m sorry your pull-request has been pending for a while, it went through my list of things to do. I will take it over to fix the conflicts with the existing codebase and make sure it’s merged in the lower branch 🙌 |
|
@CedrickOka taken over in #32489, because it's a feature; so for 4.4. Thank you again (PS: you are still the commit author 😉) 🙌 |
fabpot
added a commit
that referenced
this pull request
Aug 18, 2019
…ckOka) This PR was merged into the 4.4 branch. Discussion ---------- [Messenger] Allow exchange type headers binding | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29983 | License | MIT | Doc PR | ø Taken over #29983, as a feature for 4.4. [Apparently useful](https://www.cloudamqp.com/blog/2015-09-03-part4-rabbitmq-for-beginners-exchanges-routing-keys-bindings.html). Commits ------- 3211caa Allow exchange type headers binding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the use of headers exchange to deliver messages by defining the headers to bind.
When binding a exchange of type headers to a queue, adding the arguments allows you to define the message routing correctly.