[FrameworkBundle] Add sid_length and sid_bits_per_character session ini options in session configuration #30027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
requested changes
Jan 29, 2019
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
Show resolved
Hide resolved
|
In #29830, @pravdinalex reported that the 3.4 branch lacks support for those options as well. Was this PR intentionally opened against the master branch? |
|
As this is a new "feature" it must be against |
derrabus
reviewed
Jan 29, 2019
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
Is it? The new feature has been implemented in php itself and the HTTP Foundation component already supports it. One could argue that this PR merely solves a configuration issue of the Framework Bundle. I don't have a clear opinion on this. I've just noticed a contradiction between the linked issue and the PR and thought I should mention it. 😃 |
|
yes indeed, my first intention was to make it a bugfix for the 3.4 branch. But as it can change the behavior of the application and can be set in the application, it sounds like a new feature. But I'm open to change it. |
34f0d92 to
69a8c7b
Compare
69a8c7b to
73ca6f1
Compare
nicolas-grekas
approved these changes
Jan 30, 2019
eb91f57 to
32ad132
Compare
|
That's a new feature to me. Reports that ask for bug fixes but really ask for feature are not uncommon :) |
XuruDragon
pushed a commit
to XuruDragon/symfony-docs
that referenced
this pull request
Jan 30, 2019
derrabus
approved these changes
Jan 30, 2019
dd20abf to
0ea374c
Compare
src/Symfony/Bundle/FrameworkBundle/Resources/config/schema/symfony-1.0.xsd
Outdated
Show resolved
Hide resolved
0ea374c to
23888fa
Compare
javiereguiluz
approved these changes
Feb 7, 2019
|
rebase needed |
…ni options in configuration | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#29830 | License | MIT | Doc PR | n/a this a fix for the issue symfony#29830 After deliberation, we estimate that only `sid_length` and` sid_bits_per_character` session options should be exposed. These options à optional. For others, we recommend changing your php.ini file We can now configure the session like this : ```yaml framwork: session: sid_length: 64 //optional, recommended value is 32 sid_bits_per_character: 6 //optional, recommended value is 5 ```
23888fa to
0403e4a
Compare
done |
|
Thank you @XuruDragon. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 8, 2019
…acter session ini options in session configuration (XuruDragon) This PR was merged into the 4.3-dev branch. Discussion ---------- [FrameworkBundle] Add sid_length and sid_bits_per_character session ini options in session configuration | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29830 | License | MIT | Doc PR | n/a this a fix for the issue #29830 After deliberation, we estimate that only `sid_length` and` sid_bits_per_character` session options should be exposed. These options à optional. For others, we recommend changing your php.ini file We can now configure the session like this : ```yaml framwork: session: sid_length: 64 //optional, recommended value is 32 sid_bits_per_character: 6 //optional, recommended value is 5 ``` Commits ------- 0403e4a [FrameworkBundle] Add sid_length and sid_bits_per_character session ini options in configuration
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Feb 11, 2019
This PR was merged into the master branch. Discussion ---------- Update the documentation for the PR #30027 See symfony/symfony#30027 Added `sid_length` and `sid_vits_per_character` options Commits ------- 8e44f8e Update the documentation for the PR #30027
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this a fix for the issue #29830
After deliberation, we estimate that only
sid_lengthandsid_bits_per_charactersession options should be exposed. These options à optional.For others, we recommend changing your php.ini file
We can now configure the session like this :