Skip to content

[DependencyInjection] Added information about deprecated aliases in debug:autowiring #30075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2019

Conversation

XuruDragon
Copy link

@XuruDragon XuruDragon commented Feb 4, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets none
License MIT
Doc PR n/a

Fix and improves a bit PR #29968 and #29995

Screenshot

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Can you please share a screenshot?
It'd be nice to add some tests also.

@XuruDragon
Copy link
Author

Thanks!
Can you please share a screenshot?
It'd be nice to add some tests also.

Screenshot added.
Tests already existing, added by #29968, I've fixed one of them.

@XuruDragon XuruDragon force-pushed the deprecated-aliases branch 3 times, most recently from a57ce22 to e724fbd Compare February 5, 2019 15:39
@XuruDragon XuruDragon force-pushed the deprecated-aliases branch 4 times, most recently from 1df769c to ba10a39 Compare February 6, 2019 16:47
…ebug:autowiring

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | none
| License       | MIT
| Doc PR        | n/a

Fix and improves a bit PR symfony#29968 and symfony#29995
@nicolas-grekas
Copy link
Member

Thank you @XuruDragon.

@nicolas-grekas nicolas-grekas merged commit 3d2378d into symfony:master Feb 8, 2019
nicolas-grekas added a commit that referenced this pull request Feb 8, 2019
…ed aliases in debug:autowiring (XuruDragon)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[DependencyInjection] Added information about deprecated aliases in debug:autowiring

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | none
| License       | MIT
| Doc PR        | n/a

Fix and improves a bit PR #29968 and #29995

![Screenshot](https://i.imgur.com/GDj2NIY.png)

Commits
-------

3d2378d [DependencyInjection] Added information about deprecated aliases in debug:autowiring
@XuruDragon XuruDragon deleted the deprecated-aliases branch February 8, 2019 12:32
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019
@fabpot fabpot mentioned this pull request May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants