Skip to content

[SecurityBundle] Deprecate the normalization of the cookie names #30111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

javiereguiluz
Copy link
Member

Q A
Branch? master
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

This is an alternative solution to #24018 providing a BC layer until Symfony 5.0.

@javiereguiluz javiereguiluz added this to the next milestone Feb 8, 2019
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(worth an entry in CHANGELOG+UPGRADING files?)

@javiereguiluz javiereguiluz changed the title [SecurityBundle] Don't normalize the names of the cookies to delete [SecurityBundle] Deprecate the normalization of the cookie names Feb 8, 2019
@fabpot
Copy link
Member

fabpot commented Feb 12, 2019

Thank you @javiereguiluz.

@fabpot fabpot merged commit 36c5df4 into symfony:master Feb 12, 2019
fabpot added a commit that referenced this pull request Feb 12, 2019
…okie names (javiereguiluz)

This PR was squashed before being merged into the 4.3-dev branch (closes #30111).

Discussion
----------

[SecurityBundle] Deprecate the normalization of the cookie names

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This is an alternative solution to #24018 providing a BC layer until Symfony 5.0.

Commits
-------

36c5df4 [SecurityBundle] Deprecate the normalization of the cookie names
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019
@fabpot fabpot mentioned this pull request May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants