Skip to content

[FrameworkBundle][Translation] Added support for PHP files with trans() in translation commands #30120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2019

Conversation

yceruto
Copy link
Member

@yceruto yceruto commented Feb 8, 2019

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29085
License MIT
Doc PR -

This PR allows translation commands be able to debug and update translation messages from any PHP file/class defined as service, injecting or wiring the translator service, e.g.:

use Symfony\Component\Translation\TranslatorInterface;

class ParallelUniverseController extends AbstractController
{
    public function hello(Request $request, TranslatorInterface $translator)
    {
        // this id 'hello_message' will be extracted from translation:update
        $message = $translator->trans('hello_message'); 

        // send message to space...
    }
}

this supports all ways of wiring (auto or not): via constructor, public property, method calls, service subscriber and controller argument.

@fabpot
Copy link
Member

fabpot commented Feb 13, 2019

#29121 is now merged, can be rebased.

@yceruto yceruto force-pushed the add_php_files_support branch from 18a570a to 9f9b828 Compare February 14, 2019 00:08
@yceruto
Copy link
Member Author

yceruto commented Feb 14, 2019

Rebased (Travis failure is unrelated), ready on my side, thanks.

@fabpot
Copy link
Member

fabpot commented Feb 16, 2019

Thank you @yceruto.

@fabpot fabpot merged commit 9f9b828 into symfony:master Feb 16, 2019
fabpot added a commit that referenced this pull request Feb 16, 2019
…iles with trans() in translation commands (yceruto)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[FrameworkBundle][Translation] Added support for PHP files with trans() in translation commands

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29085
| License       | MIT
| Doc PR        | -

This PR allows translation commands be able to debug and update translation messages from any PHP file/class defined as service, injecting or wiring the `translator` service, e.g.:
```php
use Symfony\Component\Translation\TranslatorInterface;

class ParallelUniverseController extends AbstractController
{
    public function hello(Request $request, TranslatorInterface $translator)
    {
        // this id 'hello_message' will be extracted from translation:update
        $message = $translator->trans('hello_message');

        // send message to space...
    }
}
```
this supports all ways of wiring (auto or not): via constructor, public property, method calls, service subscriber and controller argument.

Commits
-------

9f9b828 Added support for PHP files with translation in translation commands
@yceruto yceruto deleted the add_php_files_support branch February 16, 2019 13:12
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019
@fabpot fabpot mentioned this pull request May 9, 2019
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request May 28, 2019
…P files (javiereguiluz)

This PR was squashed before being merged into the 4.3 branch (closes #11598).

Discussion
----------

Mentioned the extraction of translation contents from PHP files

See symfony/symfony#30120 and https://symfony.com/blog/new-in-symfony-4-3-extracting-translation-contents-from-php-files.

Commits
-------

f82ad62 Mentioned the extraction of translation contents from PHP files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants