-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[FrameworkBundle][Translation] Added support for PHP files with trans() in translation commands #30120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#29121 is now merged, can be rebased. |
18a570a
to
9f9b828
Compare
Rebased (Travis failure is unrelated), ready on my side, thanks. |
fabpot
approved these changes
Feb 14, 2019
Thank you @yceruto. |
fabpot
added a commit
that referenced
this pull request
Feb 16, 2019
…iles with trans() in translation commands (yceruto) This PR was merged into the 4.3-dev branch. Discussion ---------- [FrameworkBundle][Translation] Added support for PHP files with trans() in translation commands | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29085 | License | MIT | Doc PR | - This PR allows translation commands be able to debug and update translation messages from any PHP file/class defined as service, injecting or wiring the `translator` service, e.g.: ```php use Symfony\Component\Translation\TranslatorInterface; class ParallelUniverseController extends AbstractController { public function hello(Request $request, TranslatorInterface $translator) { // this id 'hello_message' will be extracted from translation:update $message = $translator->trans('hello_message'); // send message to space... } } ``` this supports all ways of wiring (auto or not): via constructor, public property, method calls, service subscriber and controller argument. Commits ------- 9f9b828 Added support for PHP files with translation in translation commands
Merged
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
May 28, 2019
…P files (javiereguiluz) This PR was squashed before being merged into the 4.3 branch (closes #11598). Discussion ---------- Mentioned the extraction of translation contents from PHP files See symfony/symfony#30120 and https://symfony.com/blog/new-in-symfony-4-3-extracting-translation-contents-from-php-files. Commits ------- f82ad62 Mentioned the extraction of translation contents from PHP files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows translation commands be able to debug and update translation messages from any PHP file/class defined as service, injecting or wiring the
translator
service, e.g.:this supports all ways of wiring (auto or not): via constructor, public property, method calls, service subscriber and controller argument.