[PhpunitBridge] dropping ext-zip suggestion as its no longer needed #30143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
indeed (well, composer itself might still need it, but it has 2 options) |
stof
approved these changes
Feb 11, 2019
xabbuh
approved these changes
Feb 11, 2019
fabpot
approved these changes
Feb 12, 2019
|
Thank you @scuben. |
fabpot
added a commit
that referenced
this pull request
Feb 12, 2019
…nger needed (scuben) This PR was merged into the 3.4 branch. Discussion ---------- [PhpunitBridge] dropping ext-zip suggestion as its no longer needed | Q | A | ------------- | --- | Branch? | 3.4 <!-- see below --> | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | License | MIT The zip requirement was dropped after this pull request: #29265 Commits ------- bb4b53b Update composer.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The zip requirement was dropped after this pull request: #29265