publish message with custom queue options : flags | attributes #30225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Feb 13, 2019
src/Symfony/Component/Messenger/Tests/Transport/AmqpExt/ConnectionTest.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
approved these changes
Feb 20, 2019
OskarStark
reviewed
Feb 20, 2019
| $amqpExchange->expects($this->once())->method('publish') | ||
| ->with('body', null, 1, ['delivery_mode' => 2, 'headers' => ['token' => 'uuid', 'type' => '*']]); | ||
|
|
||
| $connection = Connection::fromDsn('amqp://localhost/%2f/messages?queue[attributes][delivery_mode]=2&queue[attributes][headers][token]=uuid&queue[flags]=1', [], true, $factory); |
There was a problem hiding this comment.
line break for the parameters would be nice for further diffs and readability, otherwise 👍
OskarStark
approved these changes
Feb 20, 2019
fabpot
approved these changes
Feb 21, 2019
There was a problem hiding this comment.
@insidestyles Can you submit a PR on the docs for the new options?
|
Thank you @insidestyles. |
fabpot
added a commit
that referenced
this pull request
Feb 21, 2019
…tributes (fedor.f, insidestyles) This PR was merged into the 4.3-dev branch. Discussion ---------- publish message with custom queue options : flags | attributes | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> option for publish persistent message: `amqp://localhost/%2f/messages?queue[attributes][delivery_mode]=2&queue[flags]=1` or options: >queue: >>name: '%env(MESSENGER_QUEUE)%' >>routing_key: '%env(MESSENGER_ROUTING_KEY)%' >>attributes: >>>delivery_mode: 2 >>flags: 1 Commits ------- 5e16053 update test case for custom queue options 4532319 publish message with custom queue options : update ConnectionTest 6f9fdaf publish message with custom queue options : flags | attributes
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
option for publish persistent message:
amqp://localhost/%2f/messages?queue[attributes][delivery_mode]=2&queue[flags]=1or
options: