Skip to content

Add element to ghost in Exception #30236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2019
Merged

Conversation

przemyslaw-bogusz
Copy link
Contributor

@przemyslaw-bogusz przemyslaw-bogusz commented Feb 14, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT

Let's make love (& good code) not war. Sorry for not submitting it at least yesterday, but hopefully you will accept it, and we will be able to merge today. This will allow us to add different addons on other special ocasions.

zrzut ekranu 2019-02-14 o 09 53 42

On personal side, I dedicate it, with lots of kisses, to my wife Martha.

If you like it, just ❤️

@fabpot
Copy link
Member

fabpot commented Feb 16, 2019

Thank you @przemyslaw-bogusz.

@fabpot fabpot merged commit c8d6dd7 into symfony:master Feb 16, 2019
fabpot added a commit that referenced this pull request Feb 16, 2019
This PR was merged into the 4.3-dev branch.

Discussion
----------

Add element to ghost in Exception

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

Let's make love (& good code) not war. Sorry for not submitting it at least yesterday, but hopefully you will accept it, and we will be able to merge today. This will allow us to add different addons on other special ocasions.

![zrzut ekranu 2019-02-14 o 09 53 42](https://user-images.githubusercontent.com/35422131/52775440-0582a900-3040-11e9-8d9a-ee4959fa6982.png)

On personal side, I dedicate it, with lots of kisses, to my wife Martha.

If you like it, just ❤️

Commits
-------

c8d6dd7 Add element to ghost in Exception
@przemyslaw-bogusz
Copy link
Contributor Author

Thank you @fabpot. I will make a birthday ghost to celebrate Symfony's anniversary. Please tell me, on which day it should appear - October 18, or October 22?

@przemyslaw-bogusz przemyslaw-bogusz deleted the valentines branch February 17, 2019 08:17
@javiereguiluz
Copy link
Member

Just sharing my opinion about this proposal: even if the idea is cute ... I wouldn't have merged this for several reasons, mainly:

  • This code is super critical, because it deals with exceptions. It cannot fail, ever. The more code and features we add, the higher probability of failure.
  • Symfony is a universal application. It's for every person, every country and every culture. Sadly there is not a single event shared universally by all people on Earth. Did you know that, according to Wikipedia, Valentine's Day is banned in countries like Iran and Saudi Arabia? Did you know that in some countries, such as Israel, it's celebrated on a different day? I'm afraid that people will suggest to add another ornaments, such as for Christmas ... which again, is not a universal festivity.

I'd agree with what you said in your last comment: showing something different on Symfony's birthday (which is considered to be: October 18th 2005 at 16:27:36). That's a truly universal and non-controversial event. But I wouldn't display any other event, so I'd remove the one merged in this PR. Thanks.

@nicolas-grekas
Copy link
Member

To me, pretending to be universal shouldn't mean removing all the fun. Instead of removing, can't we add all "Valentine's" days?

@przemyslaw-bogusz
Copy link
Contributor Author

@javiereguiluz I would just like to underline that I had no intensions of hurting anybody's beliefs or feelings.

Althougth I take my job as a developer very seriously, I wanted to add a little fun and human touch to a great tool, which I - like most of us here - use almost every day. I thougth, that it would be nice, if hardcoding developer noticed something special about the exception message on a few selected occasions. I started with this one, because I believe it to be a universal message - I mean love in general, not just Valentine's Day.

As to the code itself, I don't believe that these few additional lines complicate it in a way, which would increase a chance of failure. Nevertheless, I am always open to any suggestions from an experienced developer and Symfony contributor like you. I have prepared a new addon to celebrate Symfony's anniversaries, and I am looking forward to your comments (#30326).

fabpot added a commit that referenced this pull request Feb 21, 2019
This PR was merged into the 4.3-dev branch.

Discussion
----------

Additional addons for the ghost

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

Following #30236 I've prepared two additional addons for the ghost.

The first one will display a plus on February 29, to indicate it's a leap year.
![ghost-plus](https://user-images.githubusercontent.com/35422131/53133091-3730ce00-3572-11e9-89f7-44568d796f7e.png)

The second one will display a gift on October 18, to indicate it's Symfony's birthday.
![ghost-gift](https://user-images.githubusercontent.com/35422131/53133127-5596c980-3572-11e9-8901-704785e235a8.png)

I would just like to point out that the addons are purely for fun, to amuse every hardcoding Symfony developer and offer a chance to smile on these few selected occasions.

Commits
-------

51ed942 Additional addons for the ghost
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019
@fabpot fabpot mentioned this pull request May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants