fix lost namespace in eval #30245
Merged
fix lost namespace in eval #30245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,9 +35,6 @@ protected function tearDown(): void | |||
| */ | |||
| trait KernelShutdownOnTearDownTrait | |||
| { | |||
| /** | |||
| * @return void | |||
There was a problem hiding this comment.
please keep the annotation
src/Symfony/Bundle/FrameworkBundle/Test/KernelShutdownOnTearDownTrait.php
Show resolved
Hide resolved
Tobion
approved these changes
Feb 14, 2019
fabpot
approved these changes
Feb 16, 2019
|
Thank you @fizzka. |
fabpot
added a commit
that referenced
this pull request
Feb 16, 2019
nicolas-grekas
pushed a commit
that referenced
this pull request
Feb 16, 2019
|
added to 3.4 in da325fc |
fabpot
added a commit
that referenced
this pull request
Feb 18, 2019
* 3.4:
[TwigBridge] Fix test
Remove unnecessary ProgressBar stdout writes (fixes flickering)
[Validator] improve translations for albanian ("sq") locale
[VarDumper] fix serializing Stub instances
Don't resolve the Deprecation error handler mode until a deprecation is triggered
bug #30245 fix lost namespace in eval (fizzka)
[Twig] removed usage of non-namespaced classes
added missing dot
Update validators.lt.xlf
#30172 Add the missing validation translations for the Luxembourgish …
[Debug][ErrorHandler] Preserve next error handler
nicolas-grekas
added a commit
that referenced
this pull request
Feb 19, 2019
* 4.2: [Console] Fix command testing with missing inputs [Validator] Sync no/nb translation files [Translation] Added a script to display the status of translations [Validator] Added missing translations for Norwegian (\"no\") locale #30179 [Security\Guard] bump lowest version of security-core [TwigBridge] Fix test Remove unnecessary ProgressBar stdout writes (fixes flickering) [Validator] improve translations for albanian ("sq") locale [VarDumper] fix serializing Stub instances [Validator] Added missing use statement for UnexpectedTypeException Don't resolve the Deprecation error handler mode until a deprecation is triggered bug #30245 fix lost namespace in eval (fizzka) fix lost namespace in eval [Twig] removed usage of non-namespaced classes added missing dot Update validators.lt.xlf #30172 Add the missing validation translations for the Luxembourgish … [Debug][ErrorHandler] Preserve next error handler
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix:
phpunit8 tearDown() declaration