-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Validator] add MIR card scheme #30377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nicolas-grekas
merged 1 commit into
symfony:master
from
antonch1989:issue30376-mir-card-scheme
Mar 7, 2019
Merged
[Validator] add MIR card scheme #30377
nicolas-grekas
merged 1 commit into
symfony:master
from
antonch1989:issue30376-mir-card-scheme
Mar 7, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
antonch1989
commented
Feb 25, 2019
Q | A |
---|---|
Branch? | master |
Bug fix? | no |
New feature? | yes |
BC breaks? | no |
Deprecations? | no |
Tests pass? | yes |
Fixed tickets | #30376 |
License | MIT |
OskarStark
approved these changes
Feb 25, 2019
Please add a doc PR |
Can you provide a link to a source for the card scheme? |
|
xabbuh
reviewed
Feb 26, 2019
src/Symfony/Component/Validator/Constraints/CardSchemeValidator.php
Outdated
Show resolved
Hide resolved
Docs PR: symfony/symfony-docs#11056 |
xabbuh
approved these changes
Feb 26, 2019
javiereguiluz
approved these changes
Mar 5, 2019
8e66b5b
to
aecb33a
Compare
Thank you @antonch1989. |
nicolas-grekas
added a commit
that referenced
this pull request
Mar 7, 2019
This PR was squashed before being merged into the 4.3-dev branch (closes #30377). Discussion ---------- [Validator] add MIR card scheme | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #30376 | License | MIT Commits ------- aecb33a [Validator] add MIR card scheme
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Mar 7, 2019
This PR was merged into the master branch. Discussion ---------- new valid card scheme MIR docs for symfony/symfony#30377 Commits ------- 0c136fa new valid card scheme MIR
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.