[FrameworkBundle][Routing] allow boolean container parameters for routes #30379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8a4c740 to
21f4e38
Compare
OskarStark
approved these changes
Feb 25, 2019
|
I like it, can you please send a doc PR? 🙏 |
sure 👍 wondering what exactly to add there 😄 https://symfony.com/doc/master/routing/service_container_parameters.html Should it be one of those "NEW... since Symfony 4.3 you can also use boolean parameters" box? |
|
Not sure myself how/if this should be documented :) |
|
Yes you should add a |
fabpot
approved these changes
Mar 3, 2019
|
Thank you @dmaicher. |
fabpot
added a commit
that referenced
this pull request
Mar 4, 2019
…ameters for routes (dmaicher) This PR was merged into the 4.3-dev branch. Discussion ---------- [FrameworkBundle][Routing] allow boolean container parameters for routes | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #30366 | License | MIT | Doc PR | symfony/symfony-docs#11059 This fixes #30366 and adds support for boolean container parameters in route conditions, defaults etc. Commits ------- 21f4e38 [FrameworkBundle][Routing] allow boolean container parameters for routes
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Mar 15, 2019
…eters for routes (dmaicher) This PR was merged into the master branch. Discussion ---------- [FrameworkBundle][Routing] allow boolean container parameters for routes See symfony/symfony#30379 Commits ------- d89122c Update service_container_parameters.rst
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #30366 and adds support for boolean container parameters in route conditions, defaults etc.