[WebProfilerBundle] toolbar: invisible route name in Firefox #30383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Feb 26, 2019
|
im still seeing the blue dots (#29858 (comment)) both chrome/ff
|
|
@ro0NL I can't see those blue dots, do you have a better screen than https://user-images.githubusercontent.com/1047696/53398635-6009f680-39aa-11e9-805b-0df52d6e2226.png, or indicate better where they are ? |
|
normal hover better? i think it happens because the text is wrapped in an The following additional patch solves it for me: diff --git a/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar.css.twig b/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar.css.twig
index 9c1cad2..f42e150 100644
--- a/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar.css.twig
+++ b/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar.css.twig
@@ -103,6 +103,7 @@
.sf-toolbar-block > a:hover {
display: block;
text-decoration: none;
+ color: inherit;
}
.sf-toolbar-block span { |
|
thanks @ro0NL, I would't have noticed in a hundred years, you can check the screenshot should be everything good now |
ro0NL
approved these changes
Feb 26, 2019
javiereguiluz
approved these changes
Feb 28, 2019
fabpot
approved these changes
Feb 28, 2019
|
Thank you @inmarelibero. |
fabpot
added a commit
that referenced
this pull request
Feb 28, 2019
…ox (inmarelibero) This PR was squashed before being merged into the 4.2 branch (closes #30383). Discussion ---------- [WebProfilerBundle] toolbar: invisible route name in Firefox | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29858 | License | MIT | Doc PR | - This fixes #29858, fixing a bug that prevents Route name displaying in debug toolbar on Firefox Commits ------- 6b6bd45 [WebProfilerBundle] toolbar: invisible route name in Firefox
|
thank you all, I'm happy |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #29858, fixing a bug that prevents Route name displaying in debug toolbar on Firefox