[Form] Avoid a form type extension appears many times in debug:form #30396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…red with new getExtendedTypes method
yceruto
approved these changes
Feb 27, 2019
|
Could you add a testcase for this? As before it didn’t pop up as a failure Or is this not needed? |
javiereguiluz
approved these changes
Feb 28, 2019
nicolas-grekas
approved these changes
Mar 7, 2019
|
Thank you @markitosgv. |
nicolas-grekas
added a commit
that referenced
this pull request
Mar 7, 2019
…ebug:form (markitosgv) This PR was merged into the 4.2 branch. Discussion ---------- [Form] Avoid a form type extension appears many times in debug:form | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #30394 <!-- #-prefixed issue number(s), if any --> | License | MIT This PR fixes #30394. Avoid a form type extension appears many times in debug:form command. This is caused by new 4.2 feature getExtendedTypes(). Commits ------- c4be39c [Form] Fixes debug:form appears many times as type extensions configured with new getExtendedTypes method
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #30394. Avoid a form type extension appears many times in debug:form command. This is caused by new 4.2 feature getExtendedTypes().