Skip to content

Fix getSetMethodNormalizer to correctly ignore the attributes specified in "ignored_attributes" #30461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Fix getSetMethodNormalizer to correctly ignore the attributes specified in "ignored_attributes" #30461

wants to merge 4 commits into from

Conversation

eborges78
Copy link

@eborges78 eborges78 commented Mar 6, 2019 •
edited by nicolas-grekas
Loading

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #30453
License MIT

The GetSetMethodNormalizer class correctly ignores the attributes specified in "ignored_attributes"

@nicolas-grekas nicolas-grekas changed the title Fix getSetMethodNormalizer to correctly ignore the attributes specifi… Fix getSetMethodNormalizer to correctly ignore the attributes specified in "ignored_attributes" Mar 7, 2019
nicolas-grekas
nicolas-grekas reviewed Mar 7, 2019
View reviewed changes
nicolas-grekas
nicolas-grekas reviewed Mar 7, 2019
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test case please?

@nicolas-grekas nicolas-grekas added this to the 4.2 milestone Mar 7, 2019
@eborges78 eborges78 force-pushed the ticket_30453 branch 2 times, most recently from c16690e to 4772a9e Compare March 7, 2019 12:17
@fabpot
Copy link
Member

fabpot commented Mar 30, 2019

closing as a duplicate for #30720

@fabpot fabpot closed this Mar 30, 2019
@eborges78 eborges78 deleted the ticket_30453 branch March 30, 2019 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug Ready Status: Reviewed
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
5 participants
@eborges78 @fabpot @nicolas-grekas @xabbuh @carsonbot